Merged
Conversation
Replace deprecated Docker SDK calls with their current equivalents: - Use github.com/moby/go-archive instead of github.com/docker/docker/pkg/archive for TarWithOptions (SA1019) - Use client.ImageInspect instead of the deprecated ImageInspectWithRaw (SA1019) - Drop redundant nil check before len() on RepoDigests slice (S1009)
JamieMagee
force-pushed
the
jamiemagee/fix-staticcheck-warnings
branch
from
eaa33cc to
5e01e77
Compare
truggeri
previously approved these changes
Feb 9, 2026
truggeri
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint reports four staticcheck diagnostics in
internal/infra/run.go. This PR fixes all of them.TarWithOptionsgithub.com/docker/docker/pkg/archive.TarWithOptionsis deprecated in favour ofgithub.com/moby/go-archive(already an indirect dependency). Swapped the import; the function signature is identical.ImageInspectWithRawclient.ImageInspectWithRawis deprecated in favour ofclient.ImageInspect, which drops the unused raw[]bytereturn value. Both call sites inpullImageare updated.len()len()on a nil slice returns 0, so the leadinginspect.RepoDigests == nilguard is unnecessary. Removed it.